Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(version_scheme): fixed typo sever -> semver #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lee-W merged 1 commit into commitizen-tools:master from vantaboard:fix/typo-version_scheme
Jan 13, 2024

Conversation

Copy link
Contributor

@vantaboard vantaboard commented Jan 12, 2024

Description

Fixes a typo.

image

Checklist

  • Update the documentation for the changes

Copy link

codecov bot commented Jan 12, 2024
edited
Loading

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (120d514) 97.33% compared to head (0ce193c) 97.43%.
Report is 150 commits behind head on master.

Files Patch % Lines
commitizen/cli.py 82.14% 5 Missing ⚠️
commitizen/providers/scm_provider.py 91.17% 3 Missing ⚠️
commitizen/git.py 80.00% 2 Missing ⚠️
commitizen/changelog_formats/__init__.py 97.77% 1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@
## master #959 +/- ##
==========================================
+ Coverage 97.33% 97.43% +0.09% 
==========================================
 Files 42 55 +13 
 Lines 2104 2341 +237 
==========================================
+ Hits 2048 2281 +233 
- Misses 56 60 +4 
Flag Coverage Δ
unittests 97.43% <97.93%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lee-W Lee-W added pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check pr-status: wait-for-modification and removed pr-status: wait-for-review labels Jan 13, 2024
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vantaboard , thanks for opening this PR. Could you please reword the commit to docs(version_scheme): fixed typo sever -> semver so that this PR won't trigger a version bump? You can do so by

git commit --amend
git push origin --force

Copy link
Contributor Author

Hi @vantaboard , thanks for opening this PR. Could you please reword the commit to docs(version_scheme): fixed typo sever -> semver so that this PR won't trigger a version bump? You can do so by

git commit --amend
git push origin --force

Done!

@Lee-W Lee-W merged commit a10ba84 into commitizen-tools:master Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lee-W Lee-W Lee-W approved these changes

@woile woile Awaiting requested review from woile woile is a code owner

@noirbizarre noirbizarre Awaiting requested review from noirbizarre noirbizarre is a code owner

Assignees
No one assigned
Labels
pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check pr-status: wait-for-modification pr-status: wait-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /