-
-
Notifications
You must be signed in to change notification settings - Fork 301
fix(conf): handle parse error when init #856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
woile
merged 4 commits into
commitizen-tools:master
from
Bogay:fix/init-invalid-content
Sep 22, 2023
Merged
fix(conf): handle parse error when init #856
woile
merged 4 commits into
commitizen-tools:master
from
Bogay:fix/init-invalid-content
Sep 22, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handle parse error so that the error message looks better.
woile
woile
approved these changes
Sep 22, 2023
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If there is already a config file with wrong format in cwd,
cz
would failed to parse and the exception is unhandled. #729 have fixed that for json config, but yaml and toml are not.Fixes #577
Checklist
./scripts/format
and./scripts/test
locally to ensure this change passes linter check and testExpected behavior
cz
should report there is an error when parsing config file.Steps to Test This Pull Request
Execute following commands:
and you will see error message like this:
or this:
Additional context