Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add support for cargo workspaces #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lee-W merged 1 commit into master from feat/cargo-workspaces
Jun 13, 2023
Merged

Conversation

Copy link
Member

@woile woile commented Jun 3, 2023

Description

This PR adds support for Cargo.toml workspaces.

When the root Cargo.toml of a project is:

[workspace.package]
version = "0.1.0"

In your apps you can have a Cargo.toml with:

[package]
version = { workspace = true }

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually

wesleyel reacted with hooray emoji
Copy link

codecov bot commented Jun 3, 2023
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (eb39f8b) 97.31% compared to head (ded9fef) 97.32%.

Additional details and impacted files
@@ Coverage Diff @@
## master #754 +/- ##
==========================================
+ Coverage 97.31% 97.32% +0.01% 
==========================================
 Files 42 42 
 Lines 2045 2054 +9 
==========================================
+ Hits 1990 1999 +9 
 Misses 55 55 
Flag Coverage Δ
unittests 97.32% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/providers.py 97.50% <100.00%> (+0.20%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@woile woile requested a review from Lee-W June 4, 2023 06:11
@Lee-W Lee-W merged commit 70b5963 into master Jun 13, 2023
@Lee-W Lee-W deleted the feat/cargo-workspaces branch June 13, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lee-W Lee-W Lee-W approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /