Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

test: add test for 'additional' types in conventional commits #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
woile merged 7 commits into master from fix/673-breaking-change
May 1, 2023

Conversation

Copy link
Member

@woile woile commented Apr 28, 2023 •
edited
Loading

Description

This tests should pass, relates to:
#673

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Copy link

codecov bot commented Apr 28, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.05 ⚠️

Comparison is base (6096b68) 97.38% compared to head (376427c) 97.34%.

Additional details and impacted files 
@@ Coverage Diff @@
## master #728 +/- ##
==========================================
- Coverage 97.38% 97.34% -0.05% 
==========================================
 Files 42 42 
 Lines 2029 2034 +5 
==========================================
+ Hits 1976 1980 +4 
- Misses 53 54 +1
Flag Coverage Δ
unittests 97.34% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/bump.py 100.00% <100.00%> (ø)
commitizen/defaults.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@woile woile force-pushed the fix/673-breaking-change branch from 6521f0b to 2750a51 Compare April 28, 2023 07:28
@woile woile requested a review from Lee-W April 28, 2023 07:29
@woile woile force-pushed the fix/673-breaking-change branch from 2750a51 to 8bfc98d Compare April 28, 2023 07:29


- drop support for py36

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of this @Lee-W @jenstroeger ?

It won't show the title ### BREAKING CHANGE. But it's the best I could do with the new regex, I cannot repeat the breaking group in here:

https://github.com/commitizen-tools/commitizen/pull/728/files#diff-c951de16d627d82e01eb3ce8d7c4f0b28973ffe147520620762e7140ede2dd80R115

@woile woile force-pushed the fix/673-breaking-change branch from 041d5bb to 4eae67a Compare April 28, 2023 12:33
@woile woile force-pushed the fix/673-breaking-change branch from 4eae67a to 376427c Compare April 28, 2023 12:35
Copy link
Member Author

woile commented Apr 30, 2023

@Lee-W I'm gonna merge this and #728 tomorrow, let me know of any comment, it's mostly fixes

@woile woile merged commit 6656cb4 into master May 1, 2023
@woile woile deleted the fix/673-breaking-change branch May 1, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lee-W Lee-W Awaiting requested review from Lee-W Lee-W is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant

AltStyle によって変換されたページ (->オリジナル) /