-
-
Notifications
You must be signed in to change notification settings - Fork 301
Fix/major version zero bump map #726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
before this commit, major_version_zero would only work with conventional commits, as the value used was not exposed to other cz rules
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@ ## master #726 +/- ## ========================================== - Coverage 97.42% 97.38% -0.05% ========================================== Files 42 42 Lines 2022 2029 +7 ========================================== + Hits 1970 1976 +6 - Misses 52 53 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I'm good with the PR. Just have one minor discussion. But even if we agree on that, we can open an issue and work on that later 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is not actually a default for every cz, should we move it out of defaults? I've been thinking for moving these kind of stuff from defaults for a long time but not yet have a chance to do so 🤦♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, many (not all) of those "defaults" are actually part of the conventional commit cz and we are probably creating confusion by having them there
Uh oh!
There was an error while loading. Please reload this page.
Description
It's currently not possible to modify major version zero, meaning that it only works with conventional commits.
If you have a custom rule, and you set
major_version_zeroto true, it won't find any commits, because it will be actually using the one indefaults.bump_major_version_zerowhich matches with conventional commit conventionsChecklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
Users should be able to express the behavior when major_version_zero is true, and they have a different set of rules.