-
-
Notifications
You must be signed in to change notification settings - Fork 301
feat: add --allow-no-commit option #723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #723 +/- ## ========================================== + Coverage 97.33% 97.59% +0.25% ========================================== Files 42 55 +13 Lines 2104 2617 +513 ========================================== + Hits 2048 2554 +506 - Misses 56 63 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LGTM 💪🏻 , needs tests though
🍾 Nice to see that you approve the idea.
needs tests though
absolutely, I'll work on them this week (I hope)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I recently happen to work on a project need such feature lol 🎉
@woile @noirbizarre, I picked this up and refactored it a bit. I changed the argument to --allow-no-commit. One weird thing that might happen is that one commit might have multiple versions. I'm not sure whether it would cause any issue
thanks @Lee-W
Hey @woile @noirbizarre , I just rebased it from the latest master branch. Would be nice if you could take a look. Thanks!
Should this be exposed as a config parameter as well? besides that it looks good
Should this be exposed as a config parameter as well? besides that it looks good
Yep, could be. let me update it as well. Just notice the CI also failed 🤦♂️
And there's still an issue with vsc with no commits
And there's still an issue with
vscwith no commits
I'm afraid I don't quite get this one 🤔
I'll take a look tomorrow 👍🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! (before it reaches 2 years old, sorry for that)
This feature is needed. I think we can iterate on smaller pull request to add later settings or any other adjustments
superceed #696
Description
First draft of a new feature. The idea is to grant the user the capability to run
cz bumpwithout prior commits. The reasons are described in the associated issue.here we add an
--emptyparameter to the bump methodwhen this parameter is set and if no increment is find, a automatic "PATCH" is released.
I'll wait for your feedback before working on tests and documentation.
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testAdditional context
Fix #662