-
-
Notifications
You must be signed in to change notification settings - Fork 301
Release/v3 #712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/v3 #712
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@ ## v3 #712 +/- ## ========================================== - Coverage 97.87% 97.37% -0.50% ========================================== Files 42 42 Lines 1928 2019 +91 ========================================== + Hits 1887 1966 +79 - Misses 41 53 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
f9d110c to
f26e3c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I left a few minor comments and suggests, but I'm good even if they're not addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it be a bit confusing as the default behavior for cz bump --changelog and cz changelog are different?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has always been the case. cz bump --changelog avoids messing with your changelog (this allows users to modify further the file). With cz changelog the whole file will be recreated. An alternative would be to set changelog_incremental as default = True. This way cz bump --changelog and cz changelog would behave the same. But it's another breaking change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like changelog_incremental=True as default a bit more, but would be ok if we keep it as it is
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
a6f0626 to
28ac04f
Compare
Description
Preparing commitizen for v3.