Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(bump): fixed environment variables in bump hooks #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lee-W merged 1 commit into commitizen-tools:master from skoef:fix-hooks-env-regression
Feb 25, 2023

Conversation

Copy link
Contributor

@skoef skoef commented Feb 23, 2023

During development of #644, merging the hook environment variables with existing OS variables broke. This commit fixes that. I think it got missing during an additional rebase of that MR, but it is fixed again.

@skoef skoef force-pushed the fix-hooks-env-regression branch 3 times, most recently from d7c5337 to dab8a7f Compare February 23, 2023 17:26
During development of commitizen-tools#644, merging the hook environment variables with existing OS variables broke.
@skoef skoef force-pushed the fix-hooks-env-regression branch from dab8a7f to 6659aba Compare February 23, 2023 17:29
Copy link

codecov bot commented Feb 23, 2023
edited
Loading

Codecov Report

Base: 97.92% // Head: 98.02% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (6659aba) compared to base (619e2d2).
Patch coverage: 91.81% of modified lines in pull request are covered.

Additional details and impacted files
@@ Coverage Diff @@
## master #675 +/- ##
==========================================
+ Coverage 97.92% 98.02% +0.09% 
==========================================
 Files 35 40 +5 
 Lines 1252 1720 +468 
==========================================
+ Hits 1226 1686 +460 
- Misses 26 34 +8 
Flag Coverage Δ
unittests 98.02% <91.81%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/cli.py 93.93% <ø> (ø)
commitizen/commands/init.py 87.93% <84.00%> (-3.74%) ⬇️
commitizen/hooks.py 95.65% <95.65%> (ø)
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/bump.py 100.00% <100.00%> (ø)
commitizen/cmd.py 100.00% <100.00%> (ø)
commitizen/commands/bump.py 97.46% <100.00%> (+0.15%) ⬆️
commitizen/commands/check.py 100.00% <100.00%> (ø)
commitizen/config/yaml_config.py 100.00% <100.00%> (ø)
commitizen/defaults.py 100.00% <100.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor Author

skoef commented Feb 24, 2023

@Lee-W perhaps you could take a look at it?

@Lee-W Lee-W self-requested a review February 25, 2023 07:47
@Lee-W Lee-W merged commit 3ce4ed8 into commitizen-tools:master Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lee-W Lee-W Lee-W approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /