-
-
Notifications
You must be signed in to change notification settings - Fork 301
docs(README.md): update poetry dev dependency usage #619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(README.md): update poetry dev dependency usage #619
Conversation
Since Poetry 1.2.0 dependency groups are introduced, and `--dev` becomes deprecated, and instead `--with dev` has to be provided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of just use --group, I might suggest add poetry version as well. e.g.,
# for poetry >= 1.2.0
...
# for poetry < 1.2.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Merge when you think is ready @Lee-W .
Thanks 🎉
Since Poetry 1.2.0 dependency groups are introduced, and
--devbecomes deprecated, and instead--with devhas to be provided. This PR updates the documentation to reflect this change.Description
Change the documentation in order to reflect the updated way for dependency groups.
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
The documentation can be followed as it is, instead of getting warnings/ errors.
Steps to Test This Pull Request
Additional context
image