-
-
Notifications
You must be signed in to change notification settings - Fork 301
Conditionally relax specification for termcolor dependency #587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 98.32% // Head: 98.38% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@ ## master #587 +/- ## ========================================== + Coverage 98.32% 98.38% +0.06% ========================================== Files 39 39 Lines 1614 1614 ========================================== + Hits 1587 1588 +1 + Misses 27 26 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
pyproject.toml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering why are we pinning version to < 2.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad. To follow the original caret style's intent, this should be:
termcolor = [
{ "version" = "^1.1", python = "< 3.7" },
{ "version" = ">= 1.1, < 3", python = ">= 3.7" },
If you agree, I will update the PR accordingly. Do you prefer an additional commit or should I modify and force-push?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modify and force push
...d Python versions
Thank you, @Lee-W!
Uh oh!
There was an error while loading. Please reload this page.
Description
Closes #586
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
Allow for installation of termcolor 2.x in commitizen enabled projects under Python >= 3.7
Steps to Test This Pull Request
Additional context