Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

ci(scripts): add commitizen check to CI #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lee-W merged 2 commits into master from add-commitizen-check-into-scripts-tests
Sep 18, 2022

Conversation

Copy link
Member

@Lee-W Lee-W commented Sep 17, 2022

Description

add commit check to our ./scripts/test

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

run commit check when executing ./scripts/test

Steps to Test This Pull Request

  1. ./scripts/tests

Additional context

@Lee-W Lee-W requested a review from woile September 17, 2022 13:21
pytest-regression now depends on higher version of pytest
ESSS/pytest-regressions#107 
Copy link

codecov bot commented Sep 17, 2022
edited
Loading

Codecov Report

Base: 98.38% // Head: 98.32% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (8e31a35) compared to base (f6ab845).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@ Coverage Diff @@
## master #585 +/- ##
==========================================
- Coverage 98.38% 98.32% -0.07% 
==========================================
 Files 39 39 
 Lines 1614 1614 
==========================================
- Hits 1588 1587 -1 
- Misses 26 27 +1 
Flag Coverage Δ
unittests 98.32% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/changelog.py 99.43% <0.00%> (-0.57%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@woile woile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh we use commitizen to test commitizen now 🤣 💪🏻

Lee-W reacted with laugh emoji
@Lee-W Lee-W merged commit 4f4fb4d into master Sep 18, 2022
@Lee-W Lee-W deleted the add-commitizen-check-into-scripts-tests branch September 18, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woile woile woile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /