-
-
Notifications
You must be signed in to change notification settings - Fork 302
fix(bump): Support regexes containing colons #567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The version_files feature uses a colon to delimit filenames from a regex to use to find the version. Make version_files slightly more robust by splitting on the first colon rather than all colons, thereby permitting the regex to contain a colon. Maintain the pre-existing assumption that the filename doesn't contain a colon, as this is rare and would likely cause many other problems.
Commitizen runs bump on itself to, among other things, manage the version it uses of its own pre-commit hooks. When searching .pre-commit-config.yaml for the version number of Commitizen, look for "rev:" rather than "rev" to reduce the likelihood of a false positive now that colons are permitted in version_files regexes.
Codecov ReportBase: 98.37% // Head: 98.43% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@ ## master #567 +/- ## ========================================== + Coverage 98.37% 98.43% +0.06% ========================================== Files 39 39 Lines 1603 1602 -1 ========================================== Hits 1577 1577 + Misses 26 25 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Wow! Thanks for the fix 🚀
Uh oh!
There was an error while loading. Please reload this page.
Description
Fixes #499.
The
version_filesfeature uses a colon to delimit filenames from a regex to use to find the version. Makeversion_filesslightly more robust by splitting on the first colon rather than all colons, thereby permitting the regex to contain a colon. Maintain the pre-existing assumption that the filename doesn't contain a colon, as this is rare and would likely cause many other problems.Include colon in
version_filesregex. Commitizen runs bump on itself to, among other things, manage the version it uses of its own pre-commit hooks. When searching.pre-commit-config.yamlfor the version number of Commitizen, look for"rev:"rather than"rev"to reduce the likelihood of a false positive now that colons are permitted inversion_filesregexes.Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
The version of the Commitizen pre-commit hooks is incremented along with all other references to the Commitizen version number.
Steps to Test This Pull Request
cz bump.Additional context
As mentioned in #565, I am encountering some difficulties testing Commitizen locally.