-
-
Notifications
You must be signed in to change notification settings - Fork 301
fix(commands/changelog): Fixed issue #561 cz bump could not find the latest version tag with custom tag_format #566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...d not find the latest version tag with custom tag_format - Updated args to _find_incremental_rev to use latest_tag_version instead of latest_version - Updated test case for test_changelog_command.py from .next to .rc as python packaging lib doesn't take 'next' as a valid version
Codecov ReportBase: 98.37% // Head: 98.44% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@ ## master #566 +/- ## ========================================== + Coverage 98.37% 98.44% +0.06% ========================================== Files 39 39 Lines 1603 1604 +1 ========================================== + Hits 1577 1579 +2 + Misses 26 25 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
LGTM
Description
fix(command_changelog): Fixed issue #561 cz bump could not find the latest version tag with custom tag_format
Checklist
./scripts/format
and./scripts/test
locally to ensure this change passes linter check and testExpected behavior
The changelog command will now use the tag_format_$version to lookup the git tags instead of just $version, which may fail if git tag has a long length which significally reduce the similarity
Steps to Test This Pull Request
Configuration
Commits
Command run
Additional context