-
-
Notifications
You must be signed in to change notification settings - Fork 302
use error_code to do "is_signed_tag" check to avoid language issue #543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #543 +/- ## ========================================== + Coverage 98.26% 98.32% +0.05% ========================================== Files 39 39 Lines 1556 1551 -5 ========================================== - Hits 1529 1525 -4 + Misses 27 26 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I wonder if there's a language agnostic way of doing this, instead of forcing english into the equation 🤔
I wonder if there's a language agnostic way of doing this, instead of forcing english into the equation 🤔
git tag -a testtaggit tag -v testtag || echo $?
The above exit code is 1... so it appears the exit code is 1 for annotated tag and 0 for signed tag.
side note, tmp_commitizen_project_with_gpg is creating a key every time the unit tests run. I wonder if there is a way to make them temporary.
side note, tmp_commitizen_project_with_gpg is creating a key every time the unit tests run. I wonder if there is a way to make them temporary.
Maybe we could use a context manager to remove the created key after running testing?
I wonder if there's a language agnostic way of doing this, instead of forcing english into the equation 🤔
* `git tag -a testtag` * `git tag -v testtag || echo $?`The above exit code is 1... so it appears the exit code is 1 for annotated tag and 0 for signed tag.
or also link git verify-tag <tagname> (that also print things to stdout) and then echo $? :
- 0 means signed tag
- 1 means not signed
Sorry but I did not investigate further when I created that branch.
Thanks @bhelgs and @gpongelli ! Let me update the code with the methods you provided!
@woile I think this one is now ready to be reviewed 🎉
side note, tmp_commitizen_project_with_gpg is creating a key every time the unit tests run. I wonder if there is a way to make them temporary.
Maybe we could use a context manager to remove the created key after running testing?
PR #547 handles this ;-)
Description
as title
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
pass all the test cases even when
LC_ALLis set to non-EnglishSteps to Test This Pull Request
export LC_ALL=zh_TW.UTF-8./script/testAdditional context
#542