-
-
Notifications
You must be signed in to change notification settings - Fork 301
refactor(changelog): removes unused code #541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
woile
merged 1 commit into
commitizen-tools:master
from
bhelgs:changelog_code_coverage_improvements
Aug 2, 2022
Merged
refactor(changelog): removes unused code #541
woile
merged 1 commit into
commitizen-tools:master
from
bhelgs:changelog_code_coverage_improvements
Aug 2, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #541 +/- ## ========================================== + Coverage 98.01% 98.26% +0.24% ========================================== Files 39 39 Lines 1563 1556 -7 ========================================== - Hits 1532 1529 -3 + Misses 31 27 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Lee-W
Lee-W
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
duplicate code exists in
changelog_parser.py.This bit of code seemed to be unused/untested and contributing to lower overall code coverage.
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
Steps to Test This Pull Request
Additional context