Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat(bump): make increment option case insensitive #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
woile merged 1 commit into commitizen-tools:master from edgarrmondragon:case-insensitive-increment
Jul 3, 2022
Merged

feat(bump): make increment option case insensitive #534

woile merged 1 commit into commitizen-tools:master from edgarrmondragon:case-insensitive-increment
Jul 3, 2022

Conversation

Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Jul 2, 2022 •
edited
Loading

Use str.upper to pre-process the input of --increment

Description

Support lower case arguments for the --increment option of the bump command.

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

$ cz bump --increment patch
bump: version 0.6.1 → 0.6.2
tag to create: v0.6.2
increment detected: PATCH

Steps to Test This Pull Request

Additional context

Related:

Copy link

codecov bot commented Jul 2, 2022 •
edited
Loading

Codecov Report

Merging #534 (a11f203) into master (7b69599) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@ Coverage Diff @@
## master #534 +/- ##
==========================================
+ Coverage 97.92% 98.00% +0.07% 
==========================================
 Files 39 39 
 Lines 1540 1551 +11 
==========================================
+ Hits 1508 1520 +12 
+ Misses 32 31 -1
Flag Coverage Δ
unittests 98.00% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/cli.py 93.93% <ø> (ø)
commitizen/commands/init.py 91.66% <ø> (ø)
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/commands/bump.py 96.42% <100.00%> (+1.23%) ⬆️
commitizen/commands/check.py 100.00% <100.00%> (ø)
commitizen/cz/__init__.py 100.00% <100.00%> (ø)
commitizen/defaults.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afa0d93...a11f203. Read the comment docs.

 

Use str.upper to pre-process the input of --increment
Copy link
Member

woile commented Jul 2, 2022

LGTM

@edgarrmondragon edgarrmondragon marked this pull request as ready for review July 2, 2022 19:05
Copy link
Contributor Author

LGTM

Awesome, thanks for reviewing so quickly 😅

@woile woile merged commit 5e180f7 into commitizen-tools:master Jul 3, 2022
Copy link
Member

woile commented Jul 3, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow lower case names for SemVer --increment

AltStyle によって変換されたページ (->オリジナル) /