Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: removing customization file contradiction #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lee-W merged 1 commit into commitizen-tools:master from chr15murray:patch-1
Jan 16, 2022

Conversation

Copy link
Contributor

@chr15murray chr15murray commented Jan 14, 2022

Description

Customising via the configuration file is clearly possible when using yaml files since you show an example for this. This PR updates the doc to remove the warning that states this is not possible. Given that yaml was the only missing file type in the original warning it seems safe to remove it completely.

Checklist

  • [n/a] Add test cases to all the changes you introduce
  • [n/a] Run ./script/format and ./script/test locally to ensure this change passes linter check and test
  • [n/a] Test the changes on the local machine manually
  • [*] Update the documentation for the changes

Expected behavior

N/A - Docs updated only

Steps to Test This Pull Request

N/A - Docs updated only

Additional context

N/A - Docs updated only

Customising via the configuration file is clearly possible when using yaml files since you show an example for this. This PR updates the doc to remove the warning that states this is not possible. Given that yaml was the only missing file type in the original warning it seems safe to remove it completely.
Copy link

codecov bot commented Jan 14, 2022
edited
Loading

Codecov Report

Merging #471 (293cc84) into master (308de9c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@
## master #471 +/- ##
=======================================
 Coverage 98.04% 98.04% 
=======================================
 Files 39 39 
 Lines 1431 1431 
=======================================
 Hits 1403 1403 
 Misses 28 28 
Flag Coverage Δ
unittests 98.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0647072...293cc84. Read the comment docs.

Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the doc!

chr15murray reacted with thumbs up emoji
@Lee-W Lee-W merged commit 323c72e into commitizen-tools:master Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lee-W Lee-W Lee-W approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /