-
-
Notifications
You must be signed in to change notification settings - Fork 301
docs: Fix exit code for NoCommitsFoundError #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The source code indicates that the correct exit code is 3. See https://github.com/commitizen-tools/commitizen/blob/master/commitizen/exceptions.py#L10
Codecov Report
@@ Coverage Diff @@ ## master #468 +/- ## ======================================= Coverage 98.04% 98.04% ======================================= Files 39 39 Lines 1431 1431 ======================================= Hits 1403 1403 Misses 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Lee-W
Lee-W
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source code indicates that the correct exit code is 3. See https://github.com/commitizen-tools/commitizen/blob/master/commitizen/exceptions.py#L10
Description
Update the documentation with the correct exit number
Checklist
./script/formatand./script/testlocally to ensure this change passes linter check and testThe first three entries do not apply to this PR.
Expected behavior
The documentation shows the correct information.