fix(scripts/test): excluding venv folder from pydocstyle checks #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

TheNomet wants to merge 1 commit into commitizen-tools:master from TheNomet:fix/exclude_venv_folder

Closed

fix(scripts/test): excluding venv folder from pydocstyle checks #443

TheNomet wants to merge 1 commit into commitizen-tools:master from TheNomet:fix/exclude_venv_folder

Conversation

TheNomet

Copy link

@TheNomet TheNomet commented Oct 6, 2021 •

edited

Loading

Description

Removing the venv folder from the scope of pydocstyle.
When having the venv set up in the project forlder, pydocstyle fails because of some libraries not being complainant.

Checklist

Add test cases to all the changes you introduce
Run ./script/format and ./script/test locally to ensure this change passes linter check and test
Test the changes on the local machine manually
Update the documentation for the changes

Expected behavior

When running ./scripts/test with venv folder in the project folder, the script should not fail.

Steps to Test This Pull Request

set up venv in project folder
run ./scripts/test


 fix(scripts/test): excluding venv folder from pydocstyle checks

54a438f

@codecov

Copy link

codecov bot commented Oct 6, 2021 •

edited

Loading

Codecov Report

Merging #443 (54a438f) into master (ca0e4bc) will decrease coverage by 0.53%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@
## master #443 +/- ##
==========================================
- Coverage 97.90% 97.36% -0.54% 
==========================================
 Files 39 39 
 Lines 1384 1406 +22 
==========================================
+ Hits 1355 1369 +14 
- Misses 29 37 +8

Flag	Coverage Δ
unittests	`97.36% <100.00%> (-0.54%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
commitizen/cli.py	`95.45% <ø> (-2.17%)`	⬇️
commitizen/__version__.py	`100.00% <100.00%> (ø)`
commitizen/commands/version.py	`100.00% <100.00%> (ø)`
commitizen/config/base_config.py	`90.47% <0.00%> (-9.53%)`	⬇️
commitizen/cz/base.py	`97.22% <0.00%> (-2.78%)`	⬇️
commitizen/git.py	`97.95% <0.00%> (-2.05%)`	⬇️
commitizen/__main__.py	`0.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 976d5d2...54a438f. Read the comment docs.

@Lee-W

Copy link

Member

Lee-W commented Oct 6, 2021

As we manage our env through poetry, I'm wondering why do you need venv in this directory?

@TheNomet

Copy link

Author

TheNomet commented Oct 11, 2021

That is a good point, it was my mistake to create a venv before setting up poetry. Feel free to disregard this PR.

@TheNomet TheNomet closed this

Oct 11, 2021

@TheNomet TheNomet deleted the fix/exclude_venv_folder branch

October 11, 2021 06:05

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(scripts/test): excluding venv folder from pydocstyle checks #443

fix(scripts/test): excluding venv folder from pydocstyle checks #443

Uh oh!

Conversation

@TheNomet TheNomet commented Oct 6, 2021 •

edited

Loading

Uh oh!

Description

Checklist

Expected behavior

Steps to Test This Pull Request

Uh oh!

codecov bot commented Oct 6, 2021 •

edited

Loading

Uh oh!

Codecov Report

Uh oh!

Lee-W commented Oct 6, 2021

Uh oh!

TheNomet commented Oct 11, 2021

Uh oh!

Uh oh!

Uh oh!

fix(scripts/test): excluding venv folder from pydocstyle checks #443

fix(scripts/test): excluding venv folder from pydocstyle checks #443

Uh oh!

Conversation

@TheNomet TheNomet commented Oct 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Expected behavior

Steps to Test This Pull Request

Uh oh!

codecov bot commented Oct 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Lee-W commented Oct 6, 2021

Uh oh!

TheNomet commented Oct 11, 2021

Uh oh!

Uh oh!

@TheNomet TheNomet commented Oct 6, 2021 •

edited

Loading

codecov bot commented Oct 6, 2021 •

edited

Loading