-
-
Notifications
You must be signed in to change notification settings - Fork 302
doc(#318): add documentation about WinError 995 #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the minor documentation reword. Everything looks good. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, sorry for the late review. As PyCon TW approaches, I get less time to devote to this project. Here are some errors I found on the changes.
You could test out through
poetry run mkdocs build poetry run mkdocs serve
Would be great if you could add these commands to "how to contribute" so that others can have a better idea on how to test documentation changes
Also, you might need to rebase the latest master branch into this branch to pass the test fail
31c573b to
a303a62
Compare
I still see the warning here.
image
Maybe you could try the following command to fix it
git remote add upstream git@github.com:commitizen-tools/commitizen.git git fetch upstream git rebase -i remotes/upstream/main
So now we have a single place to view all the FAQs.
53eb84c to
eb32db4
Compare
Provide the accurate versions that should solve this issue.
According to mkdoc documentation, link to another page in the same documentation can directly use file path. mkdoc documentation: https://www.mkdocs.org/user-guide/writing-your-docs/#linking-to-pages
eb32db4 to
6e567f9
Compare
Codecov Report
@@ Coverage Diff @@ ## master #431 +/- ## ========================================== - Coverage 97.92% 97.37% -0.55% ========================================== Files 39 39 Lines 1395 1409 +14 ========================================== + Hits 1366 1372 +6 - Misses 29 37 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@Lee-W sorry for lately fix and thank you for helping me to rebase the upstream. I have finished those changes.
But the test coverage seems to decrease a little, I have no idea about that. Did I break something?
These reference-style links should in `[link][id]` format instead of `[link](id)`.
b38951d to
adea200
Compare
@Bogay hmmm... that's weird. sometimes codecov just acts weird. never mind, let's merge it
Uh oh!
There was an error while loading. Please reload this page.
Description
Add some description related to #318 so that others may find the solution on documentation.
Checklist
./script/formatand./script/testlocally to ensure this change passes linter check and testExpected behavior
Steps to Test This Pull Request
Additional context