-
-
Notifications
You must be signed in to change notification settings - Fork 301
fix(changelog): annotated tags not generating proper changelog #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #388 +/- ## ========================================== + Coverage 97.67% 97.90% +0.22% ========================================== Files 39 39 Lines 1378 1381 +3 ========================================== + Hits 1346 1352 +6 + Misses 32 29 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
thanks I'll test it later.
It should works fine if you have tested it on that repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor suggestion. Other parts look good to me 👍
75ada81 to
2f5b411
Compare
2f5b411 to
72d9dbd
Compare
Closes #378
Description
Checklist
./script/formatand./script/testlocally to ensure this change passes linter check and testExpected behavior
Both annotated and not annotated tags should work.
Steps to Test This Pull Request
Additional context
Now both annotated and not annotated are detected. If there's no
objectfrom an annotated, it means we have a lightweight tag.Please also @trim21 let me know if this patch works for you