-
-
Notifications
You must be signed in to change notification settings - Fork 301
Update read configuration mode #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update read configuration mode #350
Conversation
...rb` and data type str to byte
...rb` and data type str to byte
...rb` and data type str to byte
Codecov Report
@@ Coverage Diff @@ ## master #350 +/- ## ======================================= Coverage 97.29% 97.29% ======================================= Files 35 35 Lines 999 999 ======================================= Hits 972 972 Misses 27 27
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This is great, thanks! I'd like to ask you to squash the commits and leave just one.
Something like:
fix(config): change read mode from `r` to `rb`
...into Update_read_configuration_mode
...into Update_read_configuration_mode
fix(commitizen-tools#349): Update data type support str and byte
...into Update_read_configuration_mode
...into Update_read_configuration_mode
...into Update_read_configuration_mode
Description
This MR is fix #349