-
-
Notifications
You must be signed in to change notification settings - Fork 301
feat(#319): add optional change_type_order #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #323 +/- ## ========================================== + Coverage 97.17% 97.20% +0.02% ========================================== Files 35 35 Lines 991 1000 +9 ========================================== + Hits 963 972 +9 Misses 28 28
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I think this is all done. I cleaned up the commit history so that the first commit is just a refactor to move the commit tree to a global variable for use by my new tests. The diff on the second commit are the actual changes: e855269
I've tested the changes in my personal project and all seems to work well even with custom change types: KyleKing/calcipy@4a480a8
Hi KyleKing, awesome work here! Minor correction, this is a new feature, so I'd like to ask you to rebase your PR using feat instead of fix, or if you want I can squash it and rename it, no problem.
@woile, thanks! Good point 🤦 I amended the commit message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I restored the white space changes and I think I addressed all of the comments. Thanks for the feedback!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KyleKing Thanks for your rapid update! There's only one minor exception improvement I'd like to have. I think we're almost ready to merge this one! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KyleKing Thanks for the latest update! Let's merge it back to master
Uh oh!
There was an error while loading. Please reload this page.
Description
Implements proposed feature in #319. The default change type order is
["BREAKING CHANGE", "feat", "fix", "refactor", "perf"](in descending order of importance) followed by any other change types in alphabetical order. In the configuration file, a user can override this setting to specify their own order and cover custom change types of interest.Checklist
./script/formatand./script/testlocally to ensure this change passes linter check and testExpected behavior
The
CHANGELOGshould be ordered in the user-specified order rather than FIFOSteps to Test This Pull Request
Run the standard pytest suite and see the two new test cases
Additional context
Fixes #319
Example use: KyleKing/calcipy@4a480a8