-
-
Notifications
You must be signed in to change notification settings - Fork 301
fix(commit): attach user info to backup for permission denied issue #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
woile
merged 1 commit into
commitizen-tools:master
from
SHAQ522:SHAQ522-fix-permission-deny-backup
Dec 16, 2020
Merged
fix(commit): attach user info to backup for permission denied issue #317
woile
merged 1 commit into
commitizen-tools:master
from
SHAQ522:SHAQ522-fix-permission-deny-backup
Dec 16, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multi users commit in the same machine shared backup will cause permission deny. To resolve this issue, attach user info to the name of backup commit.
Codecov Report
@@ Coverage Diff @@ ## master #317 +/- ## ======================================= Coverage 97.17% 97.17% ======================================= Files 35 35 Lines 991 991 ======================================= Hits 963 963 Misses 28 28
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Awesome, thanks! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For multi user situation, it may get fail
The reason is another user has already created a temp file with the same name.
So if one user create temp_file should attatch with
$USERinfo to resolve permission issueDescription
attach user info to temp-file name when $USER is possible
Checklist
./script/formatand./script/testlocally to ensure this change passes linter check and testExpected behavior
create
/tmp/cz.committom.backupSteps to Test This Pull Request
Additional context