-
-
Notifications
You must be signed in to change notification settings - Fork 301
Add json support for config #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add json support for config #313
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #313 +/- ## ========================================== + Coverage 96.97% 97.07% +0.10% ========================================== Files 33 34 +1 Lines 926 958 +32 ========================================== + Hits 898 930 +32 Misses 28 28
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
...onConfig class 120
...implementation 120
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I just browse through it and it looks great! I'll clone it and test it locally to confirm again and then I think we can merge it 🎉
@danvergara You'll also need to handle the json format here so that cz init can run correctly
@Lee-W thank you, man! I missed include the json support there!
@Lee-W Done!
@danvergara I just confirmed it. Let's merge it!
Description
As mentioned in #120 , this PR add json support for configuration
Checklist
./script/formatand./script/testlocally to ensure this change passes linter check and testExpected behavior
Replace a TOML config file with a JSON config file with no side effects, (of course, passing the same arguments).
Steps to Test This Pull Request
Additional context
Related to #120