-
-
Notifications
You must be signed in to change notification settings - Fork 301
fix: prevent prerelase from creating a bump when there are no commits #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #307 +/- ## ======================================= Coverage 96.96% 96.97% ======================================= Files 33 33 Lines 924 926 +2 ======================================= + Hits 896 898 +2 Misses 28 28
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
potential issue:
- can an alpha version become a beta version with no commits? if yes, then this RP breaks that behavior
solved:
this check is only triggered when going from normal release to a pre-release, not from pre-release to pre-release.
it also provides a way to fix the issue: you can transition to pre-release with no commits, but you have to manually specify the increment using --increment.
fda3017 to
7bafa42
Compare
Closes #281
Checklist
./script/formatand./script/testlocally to ensure this change passes linter check and testSteps to Test This Pull Request
Described in the issue
Additional context
This issue can only be triggered if there are commits but they are not elegible for an increment.
0.1.0cz bumo -pr alphais executed