Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat(cli): rewrite cli instructions to be more succinct about what th... #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lee-W merged 3 commits into commitizen-tools:master from alecgerona:feat/258-verbose-cli
Sep 3, 2020

Conversation

Copy link
Contributor

@alecgerona alecgerona commented Sep 2, 2020 •
edited
Loading

Closes #258

Description

Rewrite cli instructions to be more succinct about what they require.

Checklist

  • Add test cases to all the changes you introduce
  • Run ./script/format and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Steps to Test This Pull Request

1.Run cz c and view messages.

Lee-W reacted with thumbs up emoji
Copy link

codecov bot commented Sep 2, 2020 •
edited
Loading

Codecov Report

Merging #259 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph 

@@ Coverage Diff @@
## master #259 +/- ##
=======================================
 Coverage 96.61% 96.61% 
=======================================
 Files 33 33 
 Lines 915 915 
=======================================
 Hits 884 884 
 Misses 31 31
Flag Coverage Δ
#unittests 96.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...en/cz/conventional_commits/conventional_commits.py 98.41% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6efb23f...45ca91e. Read the comment docs.

@woile woile requested a review from Lee-W September 3, 2020 07:25
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Lee-W Lee-W merged commit 683317b into commitizen-tools:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woile woile woile approved these changes

@Lee-W Lee-W Lee-W approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Be more verbose about which input is required or optional

AltStyle によって変換されたページ (->オリジナル) /