-
-
Notifications
You must be signed in to change notification settings - Fork 301
feat(cz_check): cz check can read commit message from pipe #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jordanSu hmmm... I'm not able to reproduce this error on mac. I'll see whether I can do so in a docker container
24be2bd to
26f0b1f
Compare
Codecov Report
@@ Coverage Diff @@ ## master #255 +/- ## ========================================== + Coverage 96.60% 96.62% +0.02% ========================================== Files 33 33 Lines 912 919 +7 ========================================== + Hits 881 888 +7 Misses 31 31
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hmmm... it's weird. looks like the new commit is not updated to the new one but this one. I think we can keep both open untill we have this one solved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks great 🎉 We just need to fix some minor content issues. Also, I notice that you miss the period in some sentences. It'd be even better if you could take care of it
...ead commit message from pipe is added
26ff0ca to
159f6ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's merge it 👍
@jordanSu I just found out the reason why the branches are not synced. You have a typo haha (cz-pipe-messsage, cz-pipe-message)
Uh oh!
There was an error while loading. Please reload this page.
Description
As mentioned in #200, this PR makes
cz checkcan read message from pipe. In this mode, "--message" option is used.Checklist
./script/formatand./script/testlocally to ensure this change passes linter check and test (but failed)Expected behavior
String input from pipe can be read by
cz checkSteps to Test This Pull Request
echo COMMIT_MESSAGE | cz checkcat COMMIT_FILE | cz checkAdditional context
#200
This PR can't pass
./script/test, because the test "test_check_conventional_commit_succeeds" in test_check_command.py failed.However, I don't understand why this test failed, because a similar test "test_check_jira_multiple_commands" succeeded.
I put a screenshot of the error message below
Screen Shot 2020年08月31日 at 9 54 46 PM