-
-
Notifications
You must be signed in to change notification settings - Fork 301
feat(cz_check): Update to show all ill-formatted commits #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #244 +/- ## ========================================== + Coverage 96.58% 96.60% +0.01% ========================================== Files 33 33 Lines 908 912 +4 ========================================== + Hits 877 881 +4 Misses 31 31
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for your contribution! I just left some comments. Could you please add some test cases as well? Thanks!
* Update _get_commit_messages to get_commits with rev and msg info
Hello @Lee-W, thank you for your quickly review. I'll add unittests to this update these day. Thank you for your help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Let's merge it!
@Lee-W Thanks for your review! I learn a lot from it! 🙏
Uh oh!
There was an error while loading. Please reload this page.
Description
Update
cz check --rev-rangeto show all ill-formatted commits when running batch checkingChecklist
(Not sure if I need to add test case and update the docs)
./script/formatand./script/testlocally to ensure this change passes linter check and testExpected behavior
All ill-formatted commits should be displayed when running
cz check --rev-rangeSteps to Test This Pull Request
cz check --rev-range HEAD~10..HEADto check if all ill-formatted commits in the range is displayed (HEAD~10..HEADcould be replaced with any valid argument)Additional context
Solve Issue #175