Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Setup pre-commit hook in "cz init" #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
woile merged 3 commits into next from add-pre-commit-in-init-cmd
Jul 26, 2020
Merged

Setup pre-commit hook in "cz init" #236

woile merged 3 commits into next from add-pre-commit-in-init-cmd
Jul 26, 2020

Conversation

Copy link
Member

@Lee-W Lee-W commented Jul 26, 2020 •
edited
Loading

Types of changes

  • Bug fix
  • New feature
  • Refactoring
  • Breaking change (any change that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe)

Description

initial ".pre-commit-config.yaml" with cz hook through cz init

Checklist

  • Add test cases to all the changes you introduce
  • Run ./script/format and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Steps to Test This Pull Request

  1. Run cz init. Choose "Y" for "Do you want to install pre-commit hook?"

Expected behavior

  1. A ".pre-commit-config.yaml" file with cz hook should be created

Related Issue

#113

Additional context

@Lee-W Lee-W requested a review from woile July 26, 2020 15:33
Copy link

codecov bot commented Jul 26, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (next@7638381). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph 

@@ Coverage Diff @@
## next #236 +/- ##
=======================================
 Coverage ? 96.59% 
=======================================
 Files ? 33 
 Lines ? 910 
 Branches ? 0 
=======================================
 Hits ? 879 
 Misses ? 31 
 Partials ? 0
Flag Coverage Δ
#unittests 96.59% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7638381...c619c87. Read the comment docs.

@woile woile merged commit ff45e19 into next Jul 26, 2020
@woile woile deleted the add-pre-commit-in-init-cmd branch July 26, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woile woile woile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants

AltStyle によって変換されたページ (->オリジナル) /