feat(conventional_commits): use and proper support for conventional c... #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Lee-W merged 1 commit into master from feat/conventional-commits-1.0

Jul 26, 2020

Merged

feat(conventional_commits): use and proper support for conventional c... #235

Lee-W merged 1 commit into master from feat/conventional-commits-1.0

Jul 26, 2020

Conversation

woile

Copy link

Member

@woile woile commented Jul 26, 2020

...ommits v1.0.0

Types of changes

[] Bug fix
New feature
Refactoring
Breaking change (any change that would cause existing functionality to not work as expected)
Documentation update
Other (please describe)

Description

Add proper support for conventional commits 1.0
This does not introduce a breaking change for commitizen.

Checklist

Add test cases to all the changes you introduce
Run ./script/format and ./script/test locally to ensure this change passes linter check and test
Test the changes on the local machine manually

Related Issue

Closes #199

@woile


 feat(conventional_commits): use and proper support for conventional c...

a2188e5

...ommits v1.0.0

@codecov

Copy link

codecov bot commented Jul 26, 2020

Codecov Report

Merging #235 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@
## master #235 +/- ##
=======================================
 Coverage 95.70% 95.71% 
=======================================
 Files 34 34 
 Lines 955 957 +2 
=======================================
+ Hits 914 916 +2 
 Misses 41 41

Flag	Coverage Δ
#unittests	`95.71% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
commitizen/__version__.py	`100.00% <100.00%> (ø)`
...en/cz/conventional_commits/conventional_commits.py	`98.41% <100.00%> (ø)`
commitizen/git.py	`95.55% <100.00%> (+0.10%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20449e9...a2188e5. Read the comment docs.