2.0.0 breaking changes #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Lee-W merged 5 commits into next from 2.0.0-break-changes

Jul 26, 2020

Merged

2.0.0 breaking changes #230

Lee-W merged 5 commits into next from 2.0.0-break-changes

Jul 26, 2020

Conversation

Lee-W

Copy link

Member

@Lee-W Lee-W commented Jul 25, 2020

Types of changes

Bug fix
Refactoring
Breaking change (any change that would cause existing functionality to not work as expected)
Documentation update

Description

drop "files" configure support. Please use "version_files" instead
remove ini configuration support
remove "--version" argument for command line
make command required for commitizen command line

Checklist

Add test cases to all the changes you introduce
Run ./script/format and ./script/test locally to ensure this change passes linter check and test
Test the changes on the local machine manually
Update the documentation for the changes

Steps to Test This Pull Request

drop "files" configure support. Please use "version_files" instead
1. use "version_files" in the configuration file
2. use "files" in configuration file
remove ini configuration support
- use .cz, setup.cfg or .cz.cfg as configuration file
remove "--version" argument for command line
- run cz --version
make command required for commitizen command line
- run cz --debug

Expected behavior

drop "files" configure support. Please use "version_files" instead
1. versions in "version_files" should be updated
2. versions in "files" should be updated.
remove ini configuration support
- the configuration inside these files should not affect any behavior
remove "--version" argument for command line
- Command is required should show up
make command required for commitizen command line
- Command is required should show up

Related Issue

#47, #55, #82

Additional context

@Lee-W Lee-W marked this pull request as draft

July 25, 2020 14:58

Lee-W added 4 commits

July 26, 2020 16:40

@Lee-W


 fix(cli): make command required for commitizen

376d9de

BREAKING CHANGE: "cz --debug" will no longer work
 #47

@Lee-W


 refactor(cli): remove "--version" argument

67d684d

BREAKING CHANGE: Use "cz verion" instead

@Lee-W


 refactor(config): remove ini configuration support

4a20051

BREAKING CHANGE: setup.cfg, .cz and .cz.cfg are no longer supported

@Lee-W


 refactor(config): drop "files" configure support. Please use "version...

f7809df

..._files" instead
BREAKING CHANGE:
#82

@Lee-W Lee-W force-pushed the 2.0.0-break-changes branch from 5b73ad4 to f7809df Compare

July 26, 2020 08:42

@codecov

Copy link

codecov bot commented Jul 26, 2020 •

edited

Loading

Codecov Report

❗ No coverage uploaded for pull request base (next@ab91e62). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@
## next #230 +/- ##
=======================================
 Coverage ? 96.58% 
=======================================
 Files ? 33 
 Lines ? 878 
 Branches ? 0 
=======================================
 Hits ? 848 
 Misses ? 30 
 Partials ? 0

Flag	Coverage Δ
#unittests	`96.58% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab91e62...4dd29a5. Read the comment docs.