Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Update customization.md #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lee-W merged 3 commits into commitizen-tools:master from blaggacao:patch-1
Jun 10, 2020
Merged

Update customization.md #204

Lee-W merged 3 commits into commitizen-tools:master from blaggacao:patch-1
Jun 10, 2020

Conversation

Copy link
Contributor

@blaggacao blaggacao commented Jun 9, 2020 •
edited
Loading

fixes #202 - also fixes other inconsistencies which contributed to my initial confusion.

Copy link
Contributor Author

blaggacao commented Jun 9, 2020 •
edited
Loading

/cc @woile @Lee-W

| `name` | `str` | `None` | The key for the value answered by user. It's used in `message_template` |
| `message` | `str` | `None` | Detail description for the question. |
| `choices` | `list` | `None` | (OPTIONAL) The choices when `type = choice`. It should be list of dictionaries with `name` and `value`. (e.g., `[{value = "feature", name = "feature: A new feature."}, {value = "bug fix", name = "bug fix: A bug fix."}]`) |
| `choices` | `list` | `None` | (OPTIONAL) The choices when `type = list`. Either use a list of values or a list of dicitionaries with `name` and `value` keys. See examples above. |
Copy link
Contributor Author

@blaggacao blaggacao Jun 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe define the proper type set supported by upstream library in this way.

Copy link
Contributor Author

blaggacao commented Jun 9, 2020 •
edited
Loading

Please squash-merge with proper commit message I just did a quick one-shot modification over github ui to fix what caused confusion. See: https://gist.github.com/piscisaureus/3342247 to attend such contributions more easily.
Lee-W reacted with thumbs up emoji

@Lee-W Lee-W merged commit f502e08 into commitizen-tools:master Jun 10, 2020
Copy link
Member

Lee-W commented Jun 10, 2020

Thanks for updating! I just squahed and merged it.
blaggacao reacted with rocket emoji

@blaggacao blaggacao deleted the patch-1 branch June 10, 2020 02:56
Copy link
Contributor Author

Super cool, I hope it's clearer now for future readers. Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Contextual help on selections
2 participants

AltStyle によって変換されたページ (->オリジナル) /