Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Refactor config #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Lee-W wants to merge 2 commits into master from refactor-config
Closed

Refactor config #203

Lee-W wants to merge 2 commits into master from refactor-config

Conversation

Copy link
Member

@Lee-W Lee-W commented Jun 6, 2020

(Thanks for sending a pull request! Please fill in the following content to let us know better about this change.)

Types of changes

Please put an x in the box that applies

  • Bugfix
  • New feature
  • Refactoring
  • Breaking change (any change that would cause existing functionality to not work as expected)
  • Documentation Update
  • Other (please describe)

Description

  • move bump_map, bump_pattern, commit_parser from defaults to ConventionalCommitsCz

Checklist:

  • Add test cases to all the changes you introduce
  • Run ./script/lint and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Steps to Test This Pull Request

Expected behavior

No behavior should be changed.

Related Issue

#199 (comment)

Additional context

Add any other context or screenshots about the pull request here.

Copy link

codecov bot commented Jun 6, 2020 •
edited
Loading

Codecov Report

Merging #203 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph 

@@ Coverage Diff @@
## master #203 +/- ##
==========================================
- Coverage 96.58% 96.57% -0.02% 
==========================================
 Files 33 33 
 Lines 908 904 -4 
==========================================
- Hits 877 873 -4 
 Misses 31 31
Flag Coverage Δ
#unittests 96.57% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/cz/customize/customize.py 92.85% <ø> (-0.48%) ⬇️
commitizen/__version__.py 100.00% <100.00%> (ø)
...en/cz/conventional_commits/conventional_commits.py 98.43% <100.00%> (+0.02%) ⬆️
commitizen/defaults.py 100.00% <100.00%> (ø)
commitizen/cz/base.py 100.00% <0.00%> (ø)
commitizen/git.py 95.55% <0.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e24530e...c0b743f. Read the comment docs.

Copy link
Member Author

Lee-W commented Jul 26, 2021

I think this one is stale. I'll create another one to do this refactor once I have time

@Lee-W Lee-W closed this Jul 26, 2021
@Lee-W Lee-W deleted the refactor-config branch October 6, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woile woile Awaiting requested review from woile woile will be requested when the pull request is marked ready for review woile is a code owner

@noirbizarre noirbizarre Awaiting requested review from noirbizarre noirbizarre will be requested when the pull request is marked ready for review noirbizarre is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant

AltStyle によって変換されたページ (->オリジナル) /