Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Enhance GitHub template #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lee-W merged 2 commits into master from enhance-github-template
May 20, 2020
Merged

Enhance GitHub template #189

Lee-W merged 2 commits into master from enhance-github-template
May 20, 2020

Conversation

Copy link
Member

@Lee-W Lee-W commented May 20, 2020

Types of changes

Please put an x in the box that applies

  • Bugfix
  • New feature
  • Refactoring
  • Breaking change (any change that would cause existing functionality to not work as expected)
  • Documentation Update
  • Other (please describe): GitHub template

Description

  • Initial GitHub template for issues
  • Add detailed content to pull request template

Checklist:

  • Add test cases to all the changes you introduce
  • Run ./script/lint and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Steps to Test This Pull Request

  • Create a pull request/issue

Expected behavior

  • Feature Request / Bug Report / Document should appear as options when creating an issue
  • The template used in this pull request show be seen when creating a new pull request

Related Issue

Additional context

@Lee-W Lee-W force-pushed the enhance-github-template branch from 5f2dd86 to 4399ba1 Compare May 20, 2020 15:48
Copy link

codecov bot commented May 20, 2020 •
edited
Loading

Codecov Report

Merging #189 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph 

@@ Coverage Diff @@
## master #189 +/- ##
=======================================
 Coverage 92.14% 92.14% 
=======================================
 Files 35 35 
 Lines 967 967 
=======================================
 Hits 891 891 
 Misses 76 76
Flag Coverage Δ
#unittests 92.14% <100.00%> (ø)
Impacted Files Coverage Δ
commitizen/__version__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d28f6b7...4399ba1. Read the comment docs.

@woile woile requested review from woile and removed request for woile May 20, 2020 16:24
Copy link
Member

woile commented May 20, 2020

LGTM, thanks
Lee-W reacted with thumbs up emoji

@Lee-W Lee-W merged commit 5201aaf into master May 20, 2020
@Lee-W Lee-W deleted the enhance-github-template branch June 5, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants

AltStyle によって変換されたページ (->オリジナル) /