Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feature: maps and hooks #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lee-W merged 8 commits into master from feature/change-type-map
May 13, 2020
Merged

feature: maps and hooks #187

Lee-W merged 8 commits into master from feature/change-type-map
May 13, 2020

Conversation

Copy link
Member

@woile woile commented May 12, 2020

Detail

Add support for map and hooks

Checklist:

  • Run "./script/lint" and "./script/test" locally to ensure this change passes linter check and test
  • Add test cases to all the changes
  • Test the changes on the local machine manually
  • Update the documentation for the changes

@woile woile requested a review from Lee-W May 12, 2020 16:27
@woile woile force-pushed the feature/change-type-map branch 2 times, most recently from edaba14 to 4aca15b Compare May 12, 2020 16:41
Copy link

codecov bot commented May 12, 2020
edited
Loading

Codecov Report

Merging #187 into master will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@
## master #187 +/- ##
==========================================
+ Coverage 92.04% 92.14% +0.09% 
==========================================
 Files 35 35 
 Lines 955 967 +12 
==========================================
+ Hits 879 891 +12 
 Misses 76 76 
Flag Coverage Δ
#unittests 92.14% <100.00%> (+0.09%) ⬆️
Impacted Files Coverage Δ
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/commands/changelog.py 91.78% <100.00%> (+1.01%) ⬆️
commitizen/commands/version.py 100.00% <100.00%> (ø)
commitizen/cz/base.py 96.77% <100.00%> (+0.34%) ⬆️
...en/cz/conventional_commits/conventional_commits.py 92.06% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47cc712...df0042c. Read the comment docs.

Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature looks amazing! Especially the changelog_hook!

@woile woile force-pushed the feature/change-type-map branch from 94a15e6 to aa2a9f9 Compare May 13, 2020 09:17
Copy link
Member Author

woile commented May 13, 2020

Addressed most of the suggestions, only one is missing

Lee-W and woile reacted with hooray emoji

@woile woile force-pushed the feature/change-type-map branch from 72d1e75 to df0042c Compare May 13, 2020 10:31
Copy link
Member Author

woile commented May 13, 2020

If no more comments I'll merge it :D

Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it 🎉

@Lee-W Lee-W merged commit 3c687cf into master May 13, 2020
@Lee-W Lee-W deleted the feature/change-type-map branch June 5, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lee-W Lee-W Lee-W approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /