Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

fix(parsing): add option for improvement type #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fabiopedrosa wants to merge 1 commit into commitizen-tools:master from fabiopedrosa:master
Closed

fix(parsing): add option for improvement type #168

fabiopedrosa wants to merge 1 commit into commitizen-tools:master from fabiopedrosa:master

Conversation

Copy link

@fabiopedrosa fabiopedrosa commented Apr 22, 2020 •
edited
Loading

Simple PR to add the greatly missed improvement type

Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #168 into master will not change coverage.
The diff coverage is 93.44%.

Impacted file tree graph 

@@ Coverage Diff @@
## master #168 +/- ##
=======================================
 Coverage 91.84% 91.84% 
=======================================
 Files 33 33 
 Lines 785 785 
=======================================
 Hits 721 721 
 Misses 64 64
Flag Coverage Δ
#unittests 91.84% <93.44%> (ø)
Impacted Files Coverage Δ
commitizen/config/__init__.py 81.81% <50.00%> (ø)
commitizen/cz/customize/customize.py 84.78% <78.57%> (ø)
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/commands/check.py 100.00% <100.00%> (ø)
commitizen/config/base_config.py 91.66% <100.00%> (ø)
commitizen/config/ini_config.py 89.74% <100.00%> (ø)
commitizen/config/toml_config.py 93.10% <100.00%> (ø)
commitizen/cz/__init__.py 100.00% <100.00%> (ø)
commitizen/cz/base.py 100.00% <100.00%> (ø)
...en/cz/conventional_commits/conventional_commits.py 100.00% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 039f5e9...50a07bf. Read the comment docs.

Copy link
Member

Lee-W commented Apr 22, 2020

Hi, thanks for contributing! As discussed in #142, we're not planning on adding new types to cz_conventional_commit. We're using the latest types from Angular

Copy link
Author

@Lee-W ok, I see.
Lee-W reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /