refactor(Commit): refactor _prompt_commit_questions and fix some type... #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

bearomorphism wants to merge 1 commit into commitizen-tools:v4-9-2

from bearomorphism:refactor-prompt

Open

refactor(Commit): refactor _prompt_commit_questions and fix some type... #1632

bearomorphism wants to merge 1 commit into commitizen-tools:v4-9-2 from bearomorphism:refactor-prompt

+24 −18

Conversation

bearomorphism

Copy link

Contributor

@bearomorphism bearomorphism commented Sep 28, 2025

... hint

Description

Checklist

I have read the contributing guidelines

Code Changes

Add test cases to all the changes you introduce
Run poetry all locally to ensure this change passes linter check and tests
Manually test the changes:
- Verify the feature/bug fix works as expected in real-world scenarios
- Test edge cases and error conditions
- Ensure backward compatibility is maintained
- Document any manual testing steps performed
Update the documentation for the changes

Documentation Changes

Run poetry doc locally to ensure the documentation pages renders correctly
Check and fix any broken links (internal or external) in the documentation

When running poetry doc, any broken internal documentation links will be reported in the console output like this:
INFO - Doc file 'config.md' contains a link 'commands/bump.md#-post_bump_hooks', but the doc 'commands/bump.md' does not contain an anchor '#-post_bump_hooks'.

Expected Behavior

Steps to Test This Pull Request

Additional Context

@bearomorphism bearomorphism requested review from woile, Lee-W and noirbizarre as code owners

September 28, 2025 18:27

@github-actions github-actions bot added pr-status: wait-for-review type: bug type: refactor labels

Sep 28, 2025

@bearomorphism bearomorphism force-pushed the refactor-prompt branch from 5fa3486 to 5af9f3f Compare

September 28, 2025 18:27

bearomorphism

bearomorphism commented

Sep 28, 2025

View reviewed changes

commitizen/commands/commit.py

if len(subject) > limit:

raise CommitMessageLengthExceededError(

f"Length of commit message exceeds limit ({message_len}/{message_length_limit})"

f"Length of commit message exceeds limit ({len(subject)}/{limit}), subject: '{subject}'"

Copy link

Contributor Author

@bearomorphism bearomorphism Sep 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe appending more details is not a breaking change?

bearomorphism

bearomorphism commented

Sep 28, 2025

View reviewed changes

commitizen/commands/commit.py

return message

def _validate_subject_length(self, message: str) -> None:

# By the contract, message_length_limit is set to 0 for no limit

Copy link

Contributor Author

@bearomorphism bearomorphism Sep 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it still works if we use None for no limit

Copy link

Contributor Author

@bearomorphism bearomorphism Sep 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to a comment in #1574

@codecov Codecov

Copy link

codecov bot commented Sep 28, 2025 •

edited

Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (v4-9-2@939ee43). Learn more about missing BASE report.

Additional details and impacted files

@@ Coverage Diff @@
## v4-9-2 #1632 +/- ##
=========================================
 Coverage ? 98.32% 
=========================================
 Files ? 58 
 Lines ? 2685 
 Branches ? 0 
=========================================
 Hits ? 2640 
 Misses ? 45 
 Partials ? 0

Flag	Coverage Δ
unittests	`98.32% <100.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bearomorphism


 refactor(Commit): refactor _prompt_commit_questions and fix some type...

6f9fd0d

... hint

@bearomorphism bearomorphism force-pushed the refactor-prompt branch from 5af9f3f to 6f9fd0d Compare

September 28, 2025 18:43

Labels

pr-status: wait-for-review type: bug type: refactor

1 participant

@bearomorphism

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor(Commit): refactor _prompt_commit_questions and fix some type... #1632

Are you sure you want to change the base?

refactor(Commit): refactor _prompt_commit_questions and fix some type... #1632

Conversation

@bearomorphism bearomorphism commented Sep 28, 2025

Description

Checklist

Code Changes

Documentation Changes

Expected Behavior

Steps to Test This Pull Request

Additional Context

Uh oh!

@bearomorphism bearomorphism Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

@bearomorphism bearomorphism Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

@bearomorphism bearomorphism Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Sep 28, 2025 •

edited

Loading

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

refactor(Commit): refactor _prompt_commit_questions and fix some type... #1632

Are you sure you want to change the base?

refactor(Commit): refactor _prompt_commit_questions and fix some type... #1632

Conversation

@bearomorphism bearomorphism commented Sep 28, 2025

Description

Checklist

Code Changes

Documentation Changes

Expected Behavior

Steps to Test This Pull Request

Additional Context

Uh oh!

@bearomorphism bearomorphism Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

@bearomorphism bearomorphism Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

@bearomorphism bearomorphism Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

codecov bot commented Sep 28, 2025 •

edited

Loading