Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Command changelog wip #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
woile merged 8 commits into command-changelog from command-changelog-wip
May 2, 2020
Merged

Command changelog wip #163

woile merged 8 commits into command-changelog from command-changelog-wip
May 2, 2020

Conversation

Copy link
Member

@woile woile commented Apr 20, 2020 •
edited
Loading

TODO:

  • Create partial changelog from latest version. This allows people to modify the changelog manually.
  • Include --changelog flag in bump command

@woile woile marked this pull request as draft April 20, 2020 06:06
@woile woile force-pushed the command-changelog-wip branch from b53e63b to ad8d780 Compare April 21, 2020 17:23
@woile woile force-pushed the command-changelog-wip branch 2 times, most recently from 53c8237 to 99a1ae0 Compare April 25, 2020 09:10
Copy link
Member Author

woile commented Apr 28, 2020

@Lee-W this is almost ready, I need to add more tests and fix the mypy errors, maybe you wanna run it.
Lee-W reacted with thumbs up emoji

Copy link
Member

Lee-W commented Apr 29, 2020

@woile I just test it. It looks great! It seems you miss the install_requires devtools (or maybe it's not needed when we actually publish it?). Also, the latest version it generates is v1.16.4 (2020年03月03日) instead of 1.18.2 or 1.18.3.

Copy link
Member Author

woile commented Apr 29, 2020

Sorry, I'm gonna remove the debug

Also, the latest version it generates is v1.16.4 (2020年03月03日) instead of 1.18.2 or 1.18.3.

What are the steps to reproduce this?

Copy link
Member

Lee-W commented Apr 30, 2020

What are the steps to reproduce this?

Checkout this branch and run cz changelog --incremental

@woile woile force-pushed the command-changelog-wip branch 4 times, most recently from a7b3688 to bfd814e Compare May 2, 2020 08:51
Copy link

codecov bot commented May 2, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (command-changelog@5bf5542). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph 

@@ Coverage Diff @@
## command-changelog #163 +/- ##
====================================================
 Coverage ? 91.55% 
====================================================
 Files ? 35 
 Lines ? 947 
 Branches ? 0 
====================================================
 Hits ? 867 
 Misses ? 80 
 Partials ? 0
Flag Coverage Δ
#unittests 91.55% <0.00%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bf5542...aca2fe9. Read the comment docs.

@woile woile force-pushed the command-changelog-wip branch 7 times, most recently from 033b26f to dda193f Compare May 2, 2020 10:07
@woile woile marked this pull request as ready for review May 2, 2020 10:08
@woile woile force-pushed the command-changelog-wip branch from dda193f to d3c4a3c Compare May 2, 2020 10:15
@woile woile force-pushed the command-changelog-wip branch from d3c4a3c to 84471b4 Compare May 2, 2020 10:17
Copy link
Member Author

woile commented May 2, 2020

@Lee-W now is quite complete, I think it's ready to be merged into changelog-command and from there make a new release

Copy link
Member

Lee-W commented May 2, 2020

Is the default behavior now generate incremental changelog? I think this choice makes more sense. Just want to make sure everything works as you expect.

Copy link
Member Author

woile commented May 2, 2020

Yes, for now I think it should be the default behavior, specially for existing projects with an old changelog. If issues araise we can always support some arguments in the bump's changelog somehow.
I will merge later today then :D :D
Lee-W reacted with thumbs up emoji

@woile woile merged commit 9ed948a into command-changelog May 2, 2020
@Lee-W Lee-W deleted the command-changelog-wip branch May 9, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lee-W Lee-W Lee-W left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants

AltStyle によって変換されたページ (->オリジナル) /