Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

docs: add url to contact links #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lee-W merged 1 commit into commitizen-tools:master from bearomorphism:enable-blank-issue
Sep 22, 2025

Conversation

Copy link
Contributor

@bearomorphism bearomorphism commented Sep 21, 2025 •
edited
Loading

Description

  1. (Will do in a separate PR) Sometimes I still need a blank issue form... for example, the idea might be a performance improvement or test coverage improvement, which is neither documentation change, feature request or bug
  2. There should be a url field for each entry in contact_links. I added @woile 's github profile link.
image

Copy link

codecov bot commented Sep 21, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.25%. Comparing base (120d514) to head (d84356e).
⚠️ Report is 807 commits behind head on master.

Additional details and impacted files 
@@ Coverage Diff @@
## master #1627 +/- ##
==========================================
+ Coverage 97.33% 98.25% +0.91% 
==========================================
 Files 42 58 +16 
 Lines 2104 2694 +590 
==========================================
+ Hits 2048 2647 +599 
+ Misses 56 47 -9
Flag Coverage Δ
unittests 98.25% <ø> (+0.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

Lee-W commented Sep 21, 2025

or maybe let's add those types?

Copy link
Contributor Author

or maybe let's add those types?

sounds good, will do later

@bearomorphism bearomorphism marked this pull request as draft September 22, 2025 03:35
@bearomorphism bearomorphism changed the title (削除) docs: enable blank issue and add url to contact links (削除ここまで) (追記) docs: add more types of issue forms and add url to contact links (追記ここまで) Sep 22, 2025
Copy link
Contributor Author

Let me add those type of forms in a separate PR. We can fix the contact link first.

Copy link
Contributor Author

Pipeline failed... that's strange

@bearomorphism bearomorphism changed the title (削除) docs: add more types of issue forms and add url to contact links (削除ここまで) (追記) docs: add url to contact links (追記ここまで) Sep 22, 2025
Copy link
Member

Lee-W commented Sep 22, 2025 •
edited
Loading

not sure. just triggered the run

@Lee-W Lee-W merged commit 6a2c806 into commitizen-tools:master Sep 22, 2025
18 of 33 checks passed
Copy link
Contributor Author

image

Just a note that this change does work. We didn't have the 4th option before this PR.

@bearomorphism bearomorphism deleted the enable-blank-issue branch September 28, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lee-W Lee-W Lee-W approved these changes

@woile woile Awaiting requested review from woile woile is a code owner

@noirbizarre noirbizarre Awaiting requested review from noirbizarre noirbizarre is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /