-
-
Notifications
You must be signed in to change notification settings - Fork 300
refactor(BaseCommitizen): remove NotImplementedError and make them ab... #1608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Lee-W
merged 1 commit into
commitizen-tools:v4-9-2
from
bearomorphism:refactor-abstract
Sep 15, 2025
Merged
refactor(BaseCommitizen): remove NotImplementedError and make them ab... #1608
Lee-W
merged 1 commit into
commitizen-tools:v4-9-2
from
bearomorphism:refactor-abstract
Sep 15, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@bearomorphism
bearomorphism
requested review from
woile,
Lee-W and
noirbizarre
as code owners
September 15, 2025 12:11
@github-actions
github-actions
bot
added
pr-status: wait-for-review
type: refactor
labels
Sep 15, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## v4-9-2 #1608 +/- ## ========================================= Coverage ? 98.25% ========================================= Files ? 58 Lines ? 2698 Branches ? 0 ========================================= Hits ? 2651 Misses ? 47 Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Lee-W
Lee-W
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
...stract method
Description
NotImplementedErrors in the abstract classBaseCommitizenBaseCommitizen. I believe we don't need to test the abstract class.I have read the git blame to those changes. I didn't find a reason to not make them abstract.