Search code, repositories, users, issues, pull requests...

@codecov Codecov

Copy link

codecov bot commented Sep 15, 2025 •

edited

Loading

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (v4-9-2@1bb40c7). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
commitizen/commands/init.py	91.66%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@
## v4-9-2 #1604 +/- ##
=========================================
 Coverage ? 98.32% 
=========================================
 Files ? 58 
 Lines ? 2684 
 Branches ? 0 
=========================================
 Hits ? 2639 
 Misses ? 45 
 Partials ? 0

Flag	Coverage Δ
unittests	`98.32% <91.66%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bearomorphism bearomorphism force-pushed the fix-hook-types branch from 6663767 to 38e1e98 Compare

September 15, 2025 05:27

bearomorphism commented

Comment on lines -382 to -383

if hook_types is None:

hook_types = ["commit-msg", "pre-push"]

Copy link

Contributor Author

@bearomorphism bearomorphism Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch is redundant. hook_types is never None as we already checked it at callsite.

bearomorphism commented

commitizen/commands/init.py Show resolved Hide resolved

woile

woile approved these changes

@bearomorphism

Copy link

Contributor Author

bearomorphism commented Sep 15, 2025

Just adding a note that I have confirmed the issue with @Lee-W offline

bearomorphism commented

def _gen_pre_commit_cmd(self, hook_types: list[str]) -> str:

"""Generate pre-commit command according to given hook types"""

if not hook_types:

Copy link

Contributor Author

@bearomorphism bearomorphism Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This not hook_types is again redundant.

bearomorphism commented

c = cmd.run(cmd_str)

if c.return_code != 0:

raise InitFailedError(

"Failed to install pre-commit hook.\n"

Copy link

Contributor Author

@bearomorphism bearomorphism Sep 15, 2025 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added this line to keep the original behavior.

bearomorphism commented

if not self.project_info.is_pre_commit_installed:

raise InitFailedError(

"Failed to install pre-commit hook.\n"

"pre-commit is not installed in current environment."

Copy link

Contributor Author

@bearomorphism bearomorphism Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is also added to keep the original behavior.

@bearomorphism bearomorphism force-pushed the fix-hook-types branch from 2bc7b48 to 0064a9e Compare

September 15, 2025 10:15

@bearomorphism

Copy link

Contributor Author

bearomorphism commented Sep 15, 2025

Added some more changes related to hook_types to reduce complexity. Thanks.

@Lee-W Lee-W added this to the 4.9.2 milestone