fix(config): display ini config deprecation warning only when commitizen config is inside #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Lee-W merged 2 commits into master from fix-ini-warning

Apr 16, 2020

Merged

fix(config): display ini config deprecation warning only when commitizen config is inside #160

Lee-W merged 2 commits into master from fix-ini-warning

Apr 16, 2020

Conversation

Lee-W

Copy link

Member

@Lee-W Lee-W commented Apr 16, 2020

#159

@Lee-W


 fix(config): display ini config deprecation warning only when commiti...

977f98c

...zen config is inside
#159

@codecov

Copy link

codecov bot commented Apr 16, 2020 •

edited

Loading

Codecov Report

Merging #160 into master will increase coverage by 0.24%.
The diff coverage is 93.44%.

Impacted file tree graph

@@ Coverage Diff @@
## master #160 +/- ##
==========================================
+ Coverage 91.60% 91.84% +0.24% 
==========================================
 Files 33 33 
 Lines 786 785 -1 
==========================================
+ Hits 720 721 +1 
+ Misses 66 64 -2

Flag	Coverage Δ
#unittests	`91.84% <93.44%> (+0.24%)`	⬆️

Impacted Files	Coverage Δ
commitizen/config/__init__.py	`81.81% <50.00%> (-0.80%)`	⬇️
commitizen/cz/customize/customize.py	`84.78% <78.57%> (ø)`
commitizen/__version__.py	`100.00% <100.00%> (ø)`
commitizen/commands/check.py	`100.00% <100.00%> (ø)`
commitizen/config/base_config.py	`91.66% <100.00%> (ø)`
commitizen/config/ini_config.py	`89.74% <100.00%> (+5.12%)`	⬆️
commitizen/config/toml_config.py	`93.10% <100.00%> (ø)`
commitizen/cz/__init__.py	`100.00% <100.00%> (ø)`
commitizen/cz/base.py	`100.00% <100.00%> (ø)`
...en/cz/conventional_commits/conventional_commits.py	`100.00% <100.00%> (ø)`
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 400b35b...c1d780c. Read the comment docs.

@Lee-W


 test(conf): add test case for reading setup.cfg with empty config

c1d780c

@woile

Copy link

Member

woile commented Apr 16, 2020

Cool 👍

@Lee-W Lee-W merged commit f662983 into master

Apr 16, 2020

@Lee-W Lee-W deleted the fix-ini-warning branch

April 20, 2020 04:05

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(config): display ini config deprecation warning only when commitizen config is inside #160

fix(config): display ini config deprecation warning only when commitizen config is inside #160

Uh oh!

Conversation

@Lee-W Lee-W commented Apr 16, 2020

Uh oh!

codecov bot commented Apr 16, 2020 •

edited

Loading

Uh oh!

Codecov Report

Uh oh!

woile commented Apr 16, 2020

Uh oh!

Uh oh!

Uh oh!

fix(config): display ini config deprecation warning only when commitizen config is inside #160

fix(config): display ini config deprecation warning only when commitizen config is inside #160

Uh oh!

Conversation

@Lee-W Lee-W commented Apr 16, 2020

Uh oh!

codecov bot commented Apr 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

woile commented Apr 16, 2020

Uh oh!

Uh oh!

codecov bot commented Apr 16, 2020 •

edited

Loading