-
-
Notifications
You must be signed in to change notification settings - Fork 297
fix(dependency): move deprecated to project.dependencies #1591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## master #1591 +/- ## ========================================== + Coverage 97.33% 98.25% +0.91% ========================================== Files 42 58 +16 Lines 2104 2694 +590 ========================================== + Hits 2048 2647 +599 + Misses 56 47 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@woile @noirbizarre this is somewhat more urgent one. would appreciate you taking a look :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to me (make total sense !)
Uh oh!
There was an error while loading. Please reload this page.
Description
It was not caught by CI as it's part of the test group. Will need to do a hot fix and yank 4.9.0
Checklist
Code Changes
poetry all
locally to ensure this change passes linter check and testsDocumentation Changes
poetry doc
locally to ensure the documentation pages renders correctlyExpected Behavior
Steps to Test This Pull Request
Additional Context