-
-
Notifications
You must be signed in to change notification settings - Fork 296
fix(dependencies): update tomlkit version to >=0.8.0,<1.0.0 #1578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Lee-W
merged 1 commit into
commitizen-tools:v4-9-0-test
from
Narwhal-fish:fix/update-tomlkit-to-allow-empty-keys-in-pyproject-toml
Aug 24, 2025
Merged
fix(dependencies): update tomlkit version to >=0.8.0,<1.0.0 #1578
Lee-W
merged 1 commit into
commitizen-tools:v4-9-0-test
from
Narwhal-fish:fix/update-tomlkit-to-allow-empty-keys-in-pyproject-toml
Aug 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Narwhal-fish
Narwhal-fish
requested review from
woile,
Lee-W and
noirbizarre
as code owners
August 19, 2025 17:12
@Narwhal-fish
Narwhal-fish
changed the title
(削除) fix(dependencies): update tomlkit version to >=0.8.0,<1.0.0 (削除ここまで)
(追記) [WIP] fix(dependencies): update tomlkit version to >=0.8.0,<1.0.0 (追記ここまで)
Aug 19, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## v4-9-0-test #1578 +/- ## ============================================== Coverage ? 98.35% ============================================== Files ? 58 Lines ? 2671 Branches ? 0 ============================================== Hits ? 2627 Misses ? 44 Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@Narwhal-fish
Narwhal-fish
force-pushed
the
fix/update-tomlkit-to-allow-empty-keys-in-pyproject-toml
branch
from
August 21, 2025 18:14
91ee11f to
976f641
Compare
@Lee-W
Lee-W
force-pushed
the
fix/update-tomlkit-to-allow-empty-keys-in-pyproject-toml
branch
from
August 24, 2025 11:11
976f641 to
5c01885
Compare
It includes one unintentional commit. I'll go ahead and reorganize the commits a bit and then merge it
@Lee-W
Lee-W
changed the title
(削除) [WIP] fix(dependencies): update tomlkit version to >=0.8.0,<1.0.0 (削除ここまで)
(追記) fix(dependencies): update tomlkit version to >=0.8.0,<1.0.0 (追記ここまで)
Aug 24, 2025
@Lee-W
Lee-W
force-pushed
the
fix/update-tomlkit-to-allow-empty-keys-in-pyproject-toml
branch
from
August 24, 2025 11:16
5c01885 to
6ee35d1
Compare
@Lee-W
Lee-W
added
pr-status: ready-to-merge
almost ready to merge. just keep it for a few days for others to check
and removed
pr-status: wait-for-review
labels
Aug 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the
tomlkitdependency inpyproject.tomlto >=0.8.0,<1.0.0 to support parsing TOML files with empty keys (e.g.,{ "" = "src" }).This PR addresses #1573, which requests an upgrade of
tomlkit.Although the issue was discussed in tomlkit#17, the actual fix was implemented in python-poetry/tomlkit#143 and released in tomlkit v0.8.0.
Checklist
Code Changes
poetry alllocally to ensure this change passes linter check and testsDocumentation Changes
poetry doclocally to ensure the documentation pages renders correctlyExpected Behavior
Steps to Test This Pull Request
Additional Context