Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fix mypy check #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lee-W merged 17 commits into master from fix-mypy-check
Apr 13, 2020
Merged

Fix mypy check #156

Lee-W merged 17 commits into master from fix-mypy-check
Apr 13, 2020

Conversation

Copy link
Member

@Lee-W Lee-W commented Apr 9, 2020 •
edited
Loading

  • style
    • fix all the mypy warning
    • config: move .flake8 to setup.cfg and add mypy, pytest config
  • ci
    • add mypy check
    • add stricter config but comment out those we not yet follow
    • remove redundant arugment (it's been configed in setup.cfg)
  • test(cz/customize): add test case initialize_cz_customize_failed

@Lee-W Lee-W marked this pull request as draft April 9, 2020 09:45
Copy link

codecov bot commented Apr 9, 2020 •
edited
Loading

Codecov Report

Merging #156 into master will increase coverage by 0.03%.
The diff coverage is 93.10%.

Impacted file tree graph 

@@ Coverage Diff @@
## master #156 +/- ##
==========================================
+ Coverage 91.54% 91.58% +0.03% 
==========================================
 Files 33 33 
 Lines 769 784 +15 
==========================================
+ Hits 704 718 +14 
- Misses 65 66 +1
Flag Coverage Δ
#unittests 91.58% <93.10%> (+0.03%) ⬆️
Impacted Files Coverage Δ
commitizen/config/__init__.py 82.60% <50.00%> (ø)
commitizen/cz/customize/customize.py 84.78% <78.57%> (-0.22%) ⬇️
commitizen/commands/check.py 100.00% <100.00%> (ø)
commitizen/config/base_config.py 91.30% <100.00%> (ø)
commitizen/config/ini_config.py 84.61% <100.00%> (+0.83%) ⬆️
commitizen/config/toml_config.py 93.10% <100.00%> (+0.51%) ⬆️
commitizen/cz/__init__.py 100.00% <100.00%> (ø)
commitizen/cz/base.py 100.00% <100.00%> (ø)
...en/cz/conventional_commits/conventional_commits.py 100.00% <100.00%> (ø)
commitizen/cz/jira/jira.py 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d4e3b9...906d1fb. Read the comment docs.

@Lee-W Lee-W marked this pull request as ready for review April 9, 2020 10:40
Copy link
Member Author

Lee-W commented Apr 9, 2020

@woile I made some change on config files (i.e. setup.cfg) of this project. Could you check whether they make sense to you? Other than that is just fixing mypy warnings.

@Lee-W Lee-W changed the title (削除) WIP: Fix mypy check (削除ここまで) (追記) Fix mypy check (追記ここまで) Apr 10, 2020
Copy link
Member

woile commented Apr 10, 2020

Thanks for taking the time to do this!

Lee-W added 17 commits April 10, 2020 22:11
Copy link
Member Author

Lee-W commented Apr 13, 2020 •
edited
Loading

@woile If other configurations look good to you, I'll merge this pull request late today 🙂

Copy link
Member

woile commented Apr 13, 2020

Yes it's fine 👍 if any of the new settings starts annoying we can discuss about changing it.
Lee-W reacted with hooray emoji

@Lee-W Lee-W merged commit a762c9e into master Apr 13, 2020
@Lee-W Lee-W deleted the fix-mypy-check branch April 20, 2020 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woile woile woile left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants

AltStyle によって変換されたページ (->オリジナル) /