Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

fix(changelog): resolved tpl.filename type #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Copy link
Contributor

@ongdisheng ongdisheng commented Jul 6, 2025 •
edited
Loading

Description

Close #1503

Checklist

Code Changes

  • Add test cases to all the changes you introduce

Copy link

codecov bot commented Jul 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.96%. Comparing base (120d514) to head (fcb501b).
Report is 750 commits behind head on master.

Additional details and impacted files 
@@ Coverage Diff @@
## master #1556 +/- ##
==========================================
+ Coverage 97.33% 97.96% +0.62% 
==========================================
 Files 42 58 +16 
 Lines 2104 2705 +601 
==========================================
+ Hits 2048 2650 +602 
+ Misses 56 55 -1
Flag Coverage Δ
unittests 97.96% <100.00%> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ongdisheng ongdisheng marked this pull request as ready for review July 6, 2025 06:53
@Lee-W Lee-W changed the base branch from master to v4-9-0-test July 6, 2025 12:05
@Lee-W Lee-W changed the base branch from v4-9-0-test to master July 6, 2025 12:06
Copy link
Member

Lee-W commented Jul 6, 2025

let's change base branch to v4-9-0-test. we recently receive more pr than we originally expected

@ongdisheng ongdisheng changed the base branch from master to v4-9-0-test July 6, 2025 13:35
@ongdisheng ongdisheng changed the base branch from v4-9-0-test to master July 6, 2025 13:36
@ongdisheng ongdisheng deleted the fix/issue-1503 branch July 6, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woile woile Awaiting requested review from woile woile is a code owner

@Lee-W Lee-W Awaiting requested review from Lee-W Lee-W is a code owner

@noirbizarre noirbizarre Awaiting requested review from noirbizarre noirbizarre is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix tpl.filename type
2 participants

AltStyle によって変換されたページ (->オリジナル) /