Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

ci(github-actions): set organization to true for JamesIves/github-sponsors-readme-action@v1 #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lee-W merged 1 commit into master from fix-sponsor-workflow
Jun 14, 2025

Conversation

Copy link
Member

@Lee-W Lee-W commented Jun 13, 2025

Description

as title

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Documentation Changes

  • Run poetry doc locally to ensure the documentation pages renders correctly
  • Check and fix any broken links (internal or external) in the documentation

When running poetry doc, any broken internal documentation links will be reported in the console output like this:

INFO - Doc file 'config.md' contains a link 'commands/bump.md#-post_bump_hooks', but the doc 'commands/bump.md' does not contain an anchor '#-post_bump_hooks'.

Expected Behavior

Steps to Test This Pull Request

Additional Context

Copy link

codecov bot commented Jun 13, 2025
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.96%. Comparing base (120d514) to head (c08e61f).
Report is 749 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@
## master #1554 +/- ##
==========================================
+ Coverage 97.33% 97.96% +0.62% 
==========================================
 Files 42 58 +16 
 Lines 2104 2703 +599 
==========================================
+ Hits 2048 2648 +600 
+ Misses 56 55 -1 
Flag Coverage Δ
unittests 97.96% <ø> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member Author

Lee-W commented Jun 14, 2025

Since this is unlikely to cause any issues, it will most likely resolve one of the long-standing problems in the CI. I'll proceed to merge it.

@Lee-W Lee-W merged commit 2c23010 into master Jun 14, 2025
18 checks passed
@Lee-W Lee-W deleted the fix-sponsor-workflow branch June 14, 2025 03:09
Copy link
Member Author

Lee-W commented Jun 14, 2025

OK, we did fixed something but still need one more step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woile woile Awaiting requested review from woile woile is a code owner

@noirbizarre noirbizarre Awaiting requested review from noirbizarre noirbizarre is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /