Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

fix(CommitizenProvider): raise if version is None #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lee-W merged 1 commit into commitizen-tools:v4-9-0-test from bearomorphism:version
Jun 14, 2025

Conversation

Copy link
Contributor

@bearomorphism bearomorphism commented Jun 13, 2025

Description

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Copy link

codecov bot commented Jun 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v4-9-0-test@6a90185). Learn more about missing BASE report.

Additional details and impacted files 
@@ Coverage Diff @@
## v4-9-0-test #1552 +/- ##
==============================================
 Coverage ? 97.98% 
==============================================
 Files ? 58 
 Lines ? 2686 
 Branches ? 0 
==============================================
 Hits ? 2632 
 Misses ? 54 
 Partials ? 0
Flag Coverage Δ
unittests 97.98% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bearomorphism bearomorphism changed the title (削除) fix(CommitizenProvider): assert return value is not None (削除ここまで) (追記) fix(CommitizenProvider): raise if version is None (追記ここまで) Jun 13, 2025
out.write(f"{__version__}")
return

out.write(("Project Version: " if verbose else "") + version)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
out.write(("Project Version: " if verbose else"") + version)
out.write(f"Project Version: {version}" if verbose else version)

Copy link
Contributor Author

@bearomorphism bearomorphism Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Lee-W Lee-W added this to the 4.9.0 milestone Jun 13, 2025
@Lee-W Lee-W merged commit c169e09 into commitizen-tools:v4-9-0-test Jun 14, 2025
18 checks passed
@bearomorphism bearomorphism deleted the version branch June 14, 2025 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lee-W Lee-W Lee-W approved these changes

@woile woile Awaiting requested review from woile woile is a code owner

@noirbizarre noirbizarre Awaiting requested review from noirbizarre noirbizarre is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
4.9.0
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /