Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

build: add PGH003 and PGH004, add types-colorama #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lee-W merged 1 commit into commitizen-tools:refactors from bearomorphism:pgh-003
Jun 9, 2025

Conversation

Copy link
Contributor

@bearomorphism bearomorphism commented Jun 8, 2025 •
edited
Loading

Description

Related: #1501

Copy link

codecov bot commented Jun 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.96%. Comparing base (d968f26) to head (6d59fd7).
Report is 3 commits behind head on refactors.

Additional details and impacted files 
@@ Coverage Diff @@
## refactors #1517 +/- ##
=============================================
+ Coverage 97.92% 97.96% +0.03% 
=============================================
 Files 58 58 
 Lines 2704 2703 -1 
=============================================
 Hits 2648 2648 
+ Misses 56 55 -1
Flag Coverage Δ
unittests 97.96% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines 55 to +56
if getattr(Template, "substitute", None):
return message_template.substitute(**answers) # type: ignore
return message_template.substitute(**answers) # type: ignore[attr-defined,no-any-return] # pragma: no cover # TODO: check if we can fix this
Copy link
Contributor Author

@bearomorphism bearomorphism Jun 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related PR: #74

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might need to check the standard string lib 🤔

@Lee-W Lee-W merged commit 79404a4 into commitizen-tools:refactors Jun 9, 2025
18 checks passed
@bearomorphism bearomorphism deleted the pgh-003 branch June 9, 2025 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lee-W Lee-W Lee-W approved these changes

@woile woile Awaiting requested review from woile

@noirbizarre noirbizarre Awaiting requested review from noirbizarre

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /